Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filters): option to ignore accent while filtering text, closes #470 #472

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

ghiscoding
Copy link
Owner

with the option enabled and searching without accent
image

also works with accent
image



- closes #470
- add a Grid Option to filter text by ignoring any accent by normalizing the text, the option is set to false by default
@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #472 (cba9a4e) into master (a7104f3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #472   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          220       220           
  Lines        13565     13570    +5     
  Branches      4453      4458    +5     
=========================================
+ Hits         13565     13570    +5     
Impacted Files Coverage Δ
...mon/src/filter-conditions/stringFilterCondition.ts 100.00% <100.00%> (ø)
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/utilities.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7104f3...cba9a4e. Read the comment docs.

@ghiscoding ghiscoding merged commit 17d77f8 into master Sep 7, 2021
@ghiscoding ghiscoding deleted the feat/remove-string-accent branch September 7, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace accented characters with unaccented counterparts
1 participant