feat(tests): add more unit tests to vanilla bundle #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
===========================================
+ Coverage 99.82% 100.00% +0.19%
===========================================
Files 186 186
Lines 10097 10101 +4
Branches 3422 3314 -108
===========================================
+ Hits 10078 10101 +23
+ Misses 19 0 -19
Continue to review full report at Codecov.
|
ghiscoding
commented
Aug 3, 2020
| @@ -161,3 +161,4 @@ yarn run test:watch | |||
| - [ ] See if we can get `DOM Purify` to work in SF, else keep the custom sanitizer | |||
| - [ ] See if we can get all the vanilla-grid-bundle `instances` as `readonly` class members | |||
| - [ ] change `Filters` and `Editors` to default index export but move the previous export into the vanilla grid bundle | |||
There was a problem hiding this comment.
should also check lib to work with new jQuery 3.5.1 version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.