Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filters): add "target" prop to onBeforeSearchChange #796

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

ghiscoding
Copy link
Owner

  • add event target to the onBeforeSearchChange event so that we know if the filter was changed from the filter input or from the operator select dropdown

- add event target to the `onBeforeSearchChange` event so that we know if the filter was changed from the filter input or from the operator select dropdown
@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #796 (83ed91e) into master (617c88d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #796   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          236       236           
  Lines        16450     16454    +4     
  Branches      5548      5550    +2     
=========================================
+ Hits         16450     16454    +4     
Impacted Files Coverage Δ
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)
packages/common/src/filters/sliderFilter.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit c4606fd into master Nov 5, 2022
@ghiscoding ghiscoding deleted the feat/add-target-to-onbeforesearch branch November 5, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant