Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: all querySelector should be specific to a grid UID #823

Merged
merged 1 commit into from
Nov 29, 2022
Merged

fix: all querySelector should be specific to a grid UID #823

merged 1 commit into from
Nov 29, 2022

Conversation

ghiscoding
Copy link
Owner

  • we should always avoid querying the DOM without a grid UID because we might end up querying an element on the wrong grid

@ghiscoding
fix: all querySelector should be specific to a grid UID
8ea9565 
- we should always avoid querying the DOM without a grid UID because we might end up querying an element on the wrong grid
@ghiscoding ghiscoding merged commit bc2b65c into master Nov 29, 2022
@ghiscoding ghiscoding deleted the bugfix/avoid-query-selector-body branch November 29, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ghiscoding