Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(export): create custom Excel cell format with Formatters.decimal #844

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

ghiscoding
Copy link
Owner

- when using `Formatters.decimal`, the Excel export should automatically create custom format depending on decimal formatter options provided
@codecov-commenter
Copy link

Codecov Report

Merging #844 (88c9082) into master (ebabbaf) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master      #844      +/-   ##
===========================================
+ Coverage   99.97%   100.00%   +0.04%     
===========================================
  Files         239       240       +1     
  Lines       16377     16406      +29     
  Branches     5781      5785       +4     
===========================================
+ Hits        16372     16406      +34     
+ Misses          5         0       -5     
Impacted Files Coverage Δ
packages/common/src/enums/fieldType.enum.ts 100.00% <ø> (ø)
packages/excel-export/src/excelExport.service.ts 100.00% <100.00%> (+1.59%) ⬆️
packages/excel-export/src/excelUtils.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit a7a626c into master Dec 10, 2022
@ghiscoding ghiscoding deleted the bugfix/excel-formatter-decimal branch December 10, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants