Support Windows VM's #29
Conversation
| "box_download_checksum": "123456781038992207555513504e37258c29e2e9", | ||
| "box_download_checksum_type": "sha1", | ||
| "update_packages": "false", | ||
| "shutdown": "false" |
There was a problem hiding this comment.
update_packages and shutdown have to be string "false" instead of boolean false to get this to work.
Added the following to lib/rzo/app/templates/Vagrantfile.erb to aid in debugging and found that these two options were always showing as true, even if set to false here. This is odd as other options from defaults such as box work as expected.
shutdown = x<%= nc['shutdown'] %>x
update_packages = x<%= nc['update_packages'] %>x
There was a problem hiding this comment.
The false becoming true issue appears to be a "feature" or some quirk with deep_merge gem. danielsdeleo/deep_merge#23. I think the summary is that deep_merge handles values of different classes in a way that isn't entirely intuitive and true is a different class from false.
I've not yet found a way to force a false option to override the true default.
There was a problem hiding this comment.
Does it work if we convert booleans to strings and then back to booleans after the merge?
There was a problem hiding this comment.
I think so but haven't tested that approach yet. The last comment on the issue I linked seems to indicate that's a valid workaround. I'll test that out and see how viable an option that is.
No description provided.