-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.4 & 3.5 support #2246
Conversation
Mmm. This should be part of a major release. Let's merge this for psutil 6.0.0, where I will also introduce some other (not serious) incompatibilities. |
IMHO, it could also be part of a minor version bump like it was when dropping 2.6. Obviously it depends on the plans you have for minor vs major release. |
psutil/_psposix.py
Outdated
@@ -28,7 +28,7 @@ | |||
from . import _psutil_osx | |||
|
|||
|
|||
if sys.version_info >= (3, 4): | |||
if sys.version_info[0] >= 3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use PY3 constant instead.
psutil/_pslinux.py
Outdated
@@ -53,7 +53,7 @@ | |||
from ._compat import basestring | |||
|
|||
|
|||
if sys.version_info >= (3, 4): | |||
if sys.version_info[0] >= 3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use PY3 constant instead.
psutil/_pswindows.py
Outdated
@@ -56,7 +56,7 @@ | |||
else: | |||
raise | |||
|
|||
if sys.version_info >= (3, 4): | |||
if sys.version_info[0] >= 3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use PY3 constant instead.
psutil/tests/__init__.py
Outdated
@@ -67,7 +67,7 @@ | |||
warnings.simplefilter("ignore") | |||
import mock # NOQA - requires "pip install mock" | |||
|
|||
if sys.version_info >= (3, 4): | |||
if sys.version_info[0] >= 3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use PY3 constant instead.
psutil/tests/test_contracts.py
Outdated
@@ -723,7 +723,7 @@ def nice(self, ret, info): | |||
priorities = [getattr(psutil, x) for x in dir(psutil) | |||
if x.endswith('_PRIORITY_CLASS')] | |||
self.assertIn(ret, priorities) | |||
if sys.version_info > (3, 4): | |||
if sys.version_info[0] >= 3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use PY3 constant instead.
psutil/tests/test_system.py
Outdated
@@ -751,7 +751,7 @@ def test_net_if_addrs(self): | |||
self.assertIsInstance(addr.netmask, (str, type(None))) | |||
self.assertIsInstance(addr.broadcast, (str, type(None))) | |||
self.assertIn(addr.family, families) | |||
if sys.version_info >= (3, 4) and not PYPY: | |||
if sys.version_info[0] >= 3 and not PYPY: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
Signed-off-by: mayeut <mayeut@users.noreply.github.com>
Signed-off-by: mayeut <mayeut@users.noreply.github.com>
Summary
Description
Python 3.4 & 3.5 are currently untested in CI (c.f. #2162 & #2102 (comment))
Given the download count for last week below, I propose to just drop support for those versions.