Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.0.0 #30

Closed
wants to merge 2 commits into from
Closed

Release v1.0.0 #30

wants to merge 2 commits into from

Conversation

taylorbot
Copy link
Contributor

@taylorbot taylorbot commented Aug 9, 2024

Towards: giantswarm/roadmap#3522

Merge after #29

@taylorbot taylorbot requested a review from a team as a code owner August 9, 2024 21:12
@QuentinBisson
Copy link
Contributor

QuentinBisson commented Aug 11, 2024

Is there any specific reason why you want to go with 1.0.0? This has semver implications that i'm not sure we need yet?

@TheoBrigitte
Copy link
Member

Is there any specific reason why you want to go with 1.0.0? This has semver implications that i'm not sure we need yet?

There are some breaking changes introduced with this as listed in the changelog. The rules for semver says that whenever a breaking changes occurs we should bump the major version.

@QuentinBisson
Copy link
Contributor

QuentinBisson commented Aug 12, 2024

That is unless we are using major version 0 https://dev.to/malykhinvi/semver-0-x-x-46e7 😅

@TheoBrigitte
Copy link
Member

Alright let's have a minor then.

@QuentinBisson QuentinBisson deleted the main#release#major branch August 20, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants