Skip to content

Commit

Permalink
Remove giantswarm.io/monitoring: true label from the service (#1029)
Browse files Browse the repository at this point in the history
Removed `giantswarm.io/monitoring: "true"` label from the `Service` resource.

To get metrics `chart-operator` should be from now on used in conjunction with `chart-operator-extensions` version `v1.1.1` or later to deploy
`ServiceMonitor` resource for it. It was split up as `chart-operator` is one of the first component to get into
a cluster that will deploy most other things, for example Prometheus that will eventually actually deploy the
CRD for `ServiceMonitor`.
  • Loading branch information
uvegla authored Oct 4, 2023
1 parent f855d13 commit ee25a5c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ and this project's packages adheres to [Semantic Versioning](http://semver.org/s

## [Unreleased]

### Removed

- Removed `giantswarm.io/monitoring: "true"` label from the `Service` resource. To get metrics `chart-operator` should
be from now on used in conjunction with `chart-operator-extensions` version `v1.1.1` or later to deploy
`ServiceMonitor` resource for it. It was split up as `chart-operator` is one of the first component to get into
a cluster that will deploy most other things, for example Prometheus that will eventually actually deploy the
CRD for `ServiceMonitor`.

## [2.35.2] - 2023-09-26

### Fixed
Expand Down
1 change: 0 additions & 1 deletion helm/chart-operator/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ metadata:
namespace: {{ tpl .Values.resource.default.namespace . }}
labels:
{{- include "chart-operator.labels" . | nindent 4 }}
giantswarm.io/monitoring: "true"
annotations:
prometheus.io/scrape: "true"
spec:
Expand Down

0 comments on commit ee25a5c

Please sign in to comment.