set-proper-tolarate-taint-for-capi #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pinging you as well @giantswarm/team-rocket as the this will apply to on-prem CAPI as well, just wanted to make sure that this si fine for you as well |
fiunchinho
approved these changes
Sep 20, 2023
mproffitt
approved these changes
Sep 20, 2023
AndiDog
approved these changes
Sep 20, 2023
whites11
approved these changes
Sep 20, 2023
erkanerol
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The taint toleration settings for chart-operator in CNI mode (for CAPI) were too open this caused issues that the pod could be scheduled on a node that is cordoned which was causing issues for migration from vintage to CAPI
this PR changes the taint toleration to only tolerate nodes that are in the
NotReadystate