Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter CNI subnets when creating EKS NodeGroup #587

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

mnitchev
Copy link
Member

@mnitchev mnitchev commented Feb 13, 2024

Not really sure about the naming. I suppose Primary doesn't really tell you what these subnets are, but then again neither does secondary. I suppose the best way to name it is FilterNonCNI, but that may be a bit too descriptive.

@mnitchev mnitchev marked this pull request as ready for review February 14, 2024 09:09
@mnitchev mnitchev requested a review from a team February 14, 2024 09:09
Copy link

@calvix calvix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnitchev mnitchev merged commit e9c5ab6 into release-2.3 Feb 20, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants