Delete machine pool user data files that did not get deleted yet by the lifecycle policy #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
fiunchinho
reviewed
Jun 17, 2024
Comment on lines
+124
to
+127
| // Stop on last page of results | ||
| if len(out.Contents) == 0 { | ||
| break | ||
| } |
There was a problem hiding this comment.
Any reason to avoid using the built-in paginator? https://aws.github.io/aws-sdk-go-v2/docs/making-requests/#using-paginators
fiunchinho
reviewed
Jun 17, 2024
| @@ -97,6 +97,47 @@ func (s *Service) DeleteBucket() error { | |||
|
|
|||
| log.Info("Deleting S3 Bucket") | |||
|
|
|||
| // Delete machine pool user data files that did not get deleted | |||
| // yet by the lifecycle policy | |||
| for { | |||
There was a problem hiding this comment.
The machinepool feature is a feature that needs to be enabled using feature flags. We should probably check the feature flag before executing this logic.
|
I tested it, and it works like a charm. I'm going to go ahead and merge it, and talk to Andreas when he's back about the comments I wrote in the PR, just in case there is room for improvement, that we can do later on. |
fiunchinho
approved these changes
Jun 20, 2024
fiunchinho
pushed a commit
that referenced
this pull request
Jul 1, 2024
…he lifecycle policy (#593) * Delete machine pool user data files that did not get deleted yet by the lifecycle policy * Use paging for S3 results * Log S3 list operation * Handle NotFound
This was referenced Jul 1, 2024
Merged
fiunchinho
added a commit
that referenced
this pull request
Jul 4, 2024
* Add Giant Swarm fork modifications * Push to Azure registry * aws-cni-deleted-helm-managed-resources * import-order * Filter CNI subnets when creating EKS NodeGroup * add godoc * 🐛 Create a `aws.Config` with region to be able to work different AWS partition (like gov cloud or china AWS partition) (#588) * create-aws-client-with-region * 🐛 Add ID to secondary subnets (#589) * give name to secondary subnets * make linter happy * Add non root volumes to AWSMachineTemplate * Support adding custom secondary VPC CIDR blocks in `AWSCluster` (backport) (#590) * S3 user data support for `AWSMachinePool` (#592) * Delete machine pool user data files that did not get deleted yet by the lifecycle policy (#593) * Delete machine pool user data files that did not get deleted yet by the lifecycle policy * Use paging for S3 results * Log S3 list operation * Handle NotFound * Remove duplicated argument * Add `make test` to Circle CI build, S3 test fixes (#596) * Cancel instance refresh on any relevant change to ASG instead of blocking until previous one is finished (which may have led to failing nodes due to outdated join token) (#598) * Use feature gate for S3 storage (#599) * Fixes after cherry-pick our customizations --------- Co-authored-by: Andreas Sommer <andreas@giantswarm.io> Co-authored-by: calvix <vaclav@giantswarm.io> Co-authored-by: Mario Nitchev <marionitchev@gmail.com> Co-authored-by: calvix <rozsypalek.vaclav@gmail.com>
fiunchinho
pushed a commit
that referenced
this pull request
Aug 21, 2024
…he lifecycle policy (#593) * Delete machine pool user data files that did not get deleted yet by the lifecycle policy * Use paging for S3 results * Log S3 list operation * Handle NotFound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#3442, fix for #592