Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set Ignition user data storage type to S3 bucket objects for machine pools #981

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Dec 30, 2024

What this PR does / why we need it

This is a no-op right now as our fork still defaults to S3 storage, but needed because the upstream CAPA feature PR changes the default back to storage directly on the EC2 instance (for backward compatibility), so we must adapt configuration to explicitly choose the desired storage in S3.

Checklist

  • Updated CHANGELOG.md.

Trigger E2E tests

/run cluster-test-suites TARGET_SUITES=./providers/capa/standard

@AndiDog AndiDog requested a review from a team as a code owner December 30, 2024 13:13
Copy link
Contributor

There were differences in the rendered Helm template, please check! ⚠️

Output
=== Differences when rendered with values file helm/cluster-aws/ci/test-auditd-values.yaml ===

/spec/ignition  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-minimal-pool0)
  + one map entry added:
    storageType: ClusterObjectStore # store user data in S3 bucket



=== Differences when rendered with values file helm/cluster-aws/ci/test-eni-mode-values.yaml ===

/spec/ignition  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-pool0)
  + one map entry added:
    storageType: ClusterObjectStore # store user data in S3 bucket



=== Differences when rendered with values file helm/cluster-aws/ci/test-lifecycle-hook-heartbeattimeout-values.yaml ===

/spec/ignition  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-minimal-pool0)
  + one map entry added:
    storageType: ClusterObjectStore # store user data in S3 bucket



=== Differences when rendered with values file helm/cluster-aws/ci/test-local-registry-cache-values.yaml ===

/spec/ignition  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-pool0)
  + one map entry added:
    storageType: ClusterObjectStore # store user data in S3 bucket



=== Differences when rendered with values file helm/cluster-aws/ci/test-mc-proxy-values.yaml ===

/spec/ignition  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-mc-proxy-pool0)
  + one map entry added:
    storageType: ClusterObjectStore # store user data in S3 bucket



=== Differences when rendered with values file helm/cluster-aws/ci/test-multiple-authenticated-mirrors-values.yaml ===

/spec/ignition  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-pool0)
  + one map entry added:
    storageType: ClusterObjectStore # store user data in S3 bucket



=== Differences when rendered with values file helm/cluster-aws/ci/test-multiple-service-account-issuers-values.yaml ===

/spec/ignition  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-pool0)
  + one map entry added:
    storageType: ClusterObjectStore # store user data in S3 bucket



=== Differences when rendered with values file helm/cluster-aws/ci/test-network-topology-values.yaml ===

/spec/ignition  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-minimal-pool0)
  + one map entry added:
    storageType: ClusterObjectStore # store user data in S3 bucket



=== Differences when rendered with values file helm/cluster-aws/ci/test-spot-instances-values.yaml ===

/spec/ignition  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-minimal-pool0)
  + one map entry added:
    storageType: ClusterObjectStore # store user data in S3 bucket



=== Differences when rendered with values file helm/cluster-aws/ci/test-subnet-tags-values.yaml ===

/spec/ignition  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-pool0)
  + one map entry added:
    storageType: ClusterObjectStore # store user data in S3 bucket



=== Differences when rendered with values file helm/cluster-aws/ci/test-wc-minimal-values.yaml ===

/spec/ignition  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-minimal-pool0)
  + one map entry added:
    storageType: ClusterObjectStore # store user data in S3 bucket

@tinkerers-ci
Copy link

tinkerers-ci bot commented Dec 30, 2024

cluster-test-suites

Run name pr-cluster-aws-981-cluster-test-suitesd9vkh
Commit SHA c1761d5
Result Completed ✅

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites


Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@Gacko
Copy link
Member

Gacko commented Dec 31, 2024

Would it make sense to have this configurable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants