Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alloy mixin update script and Makefile #607

Merged
merged 6 commits into from
Aug 22, 2024
Merged

Conversation

TheoBrigitte
Copy link
Member

@TheoBrigitte TheoBrigitte commented Aug 20, 2024

Towards: giantswarm/roadmap#3522

Towards: giantswarm/roadmap#3522

This PR is an attempt at adding some automation to fetch Alloy mixin dashboards from https://github.com/grafana/alloy/tree/main/operations/alloy-mixin/dashboards

I am unsure how scripts are organized/run in this repository and would appreciate some guidance on this.

@TheoBrigitte TheoBrigitte requested a review from a team as a code owner August 20, 2024 17:03
@TheoBrigitte TheoBrigitte self-assigned this Aug 20, 2024
@TheoBrigitte
Copy link
Member Author

Running this script produces the following output

image

@TheoBrigitte
Copy link
Member Author

Dashboards screenshots

image
image
image

broken needs to be fixed
image

empty since not otel receiver are configured
image

image
image

@QuentinBisson
Copy link
Contributor

Well I actually went into a totally different direction for mimir and loki mixins which to me is way easier to use than your script https://github.com/giantswarm/dashboards/blob/main/mimir/update.sh also because I can read it and it's not using things like grizzly which I'm not sure we need

@QuentinBisson
Copy link
Contributor

Now we can probably merge the 2 scripts together because i almost have the same script for loki. The interesting things about my script is that we can do some edits

@TheoBrigitte
Copy link
Member Author

Well I actually went into a totally different direction for mimir and loki mixins which to me is way easier to use than your script https://github.com/giantswarm/dashboards/blob/main/mimir/update.sh also because I can read it and it's not using things like grizzly which I'm not sure we need

I changed my script to something simpler and also made use of mixtool instead of grizzly, which directly produces dashboards as json files instead grizzly CRs.

Now we can probably merge the 2 scripts together because i almost have the same script for loki. The interesting things about my script is that we can do some edits

I've kept the script separate for now, we can revisit this later on. I wanted to keep things as "simple" as possible here.


I also made other modifications along the way

  • Added Makefile.custom.mk to group scripts usage
    • Added make update-mixin to update mixin dasbhboards
    • Added make update-mimir-mixin to update Mimir mixin dashboards
    • Added make update-alloy-mixin to update Alloy mixin dashboards
    • Added make lint-dashboards to dashboards linting
    • Added make install-tools to install required tools
  • Added scripts/update-alloy-mixin.sh to update the Alloy mixin dashboards

Makefile Show resolved Hide resolved
Makefile.custom.mk Outdated Show resolved Hide resolved
TheoBrigitte and others added 2 commits August 22, 2024 16:43
Co-authored-by: Quentin Bisson <quentin@giantswarm.io>
@TheoBrigitte TheoBrigitte merged commit 4032839 into main Aug 22, 2024
4 checks passed
@TheoBrigitte TheoBrigitte deleted the alloy-dashboards branch August 22, 2024 14:47
@TheoBrigitte TheoBrigitte changed the title Update script to fetch Alloy mixin dashboards Add Alloy mixin update script and Makefile Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants