add metrics #21
add metrics #21
Conversation
| @@ -29,6 +30,11 @@ type ProviderCredential struct { | |||
| Credentials map[string]string `yaml:"credentials"` | |||
| } | |||
|
|
|||
| type ProviderApp struct { | |||
There was a problem hiding this comment.
Instead of just the connector, we return this struct now that also contains the time of secret expiry. We can also use it to add more properties later in case that's needed.
| @@ -0,0 +1,89 @@ | |||
| package azure | |||
There was a problem hiding this comment.
Moved some secret related functions to its own file.
| "gopkg.in/yaml.v2" | ||
| ) | ||
|
|
||
| type azureSecret struct { |
There was a problem hiding this comment.
Also adding a struct for the secret since returning a bunch of strings is messy and error prone.
| "app_registration_name", | ||
| } | ||
|
|
||
| AppInfo = prometheus.NewGaugeVec( |
There was a problem hiding this comment.
This is the prometheus metric. We create a row for each dex app registration. Its value is the expiry date of the client secret.
|
|
||
| // Gauge for secret expiry time | ||
| var ( | ||
| infoLabels = []string{ |
There was a problem hiding this comment.
These are the labels we set on the metrics.
| default: | ||
| return dexConfig, microerror.Maskf(invalidConfigError, "Owner %s is not known.", provider.GetOwner()) | ||
| } | ||
| AppInfo.WithLabelValues(s.app.Name, s.app.Namespace, provider.GetOwner(), provider.GetType(), provider.GetName(), appConfig.Name).Set(float64(providerApp.SecretEndDateTime.Unix())) |
There was a problem hiding this comment.
Metric is updated for each registered provider in each loop.
| @@ -179,3 +180,8 @@ func (r *AppReconciler) NewProvider(p provider.ProviderCredential) (provider.Pro | |||
| } | |||
| return nil, microerror.Maskf(invalidConfigError, "%s is not a valid provider name.", p.Name) | |||
| } | |||
|
|
|||
| func init() { | |||
There was a problem hiding this comment.
this function registers the metric
|
I tested this and it works fine. Example of a grafana table showing some of the labels:
|
towards giantswarm/roadmap#1809
this adds a metric containing info about dex app registrations