Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deployment of dex-operator to MC #3

Merged
merged 8 commits into from
Oct 17, 2022
Merged

Enable deployment of dex-operator to MC #3

merged 8 commits into from
Oct 17, 2022

Conversation

anvddriesch
Copy link
Contributor

@anvddriesch anvddriesch commented Oct 11, 2022

Towards giantswarm/roadmap#1432

This includes various changes to the helm chart, makefile and formatting of the config secret to make the operator functional on MCs.

@anvddriesch anvddriesch self-assigned this Oct 11, 2022
@@ -10,7 +10,7 @@ jobs:
- checkout
- run:
name: "Run tests"
command: CGO_ENABLED=0 make test
command: CGO_ENABLED=0 make test-all
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed the target as it is overridden by the giant swarm defaults otherwise

@@ -0,0 +1,152 @@

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just the makefile that kubebuilder creates by default. Renamed so that it does not get overwritten by Align Files

@@ -6,4 +6,4 @@ home: "https://github.com/giantswarm/dex-operator"
apiVersion: v1
annotations:
application.giantswarm.io/team: "rainbow"
config.giantswarm.io/version: 1.x.x
config.giantswarm.io/version: "dex-operator"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still using a branch of config for the operator default values

@@ -0,0 +1,23 @@
package dex
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the dex package includes the types we need to marshal the dex config

@anvddriesch
Copy link
Contributor Author

The controller works when it's deployed. :)
logs from test installation:

1.6656579833182502e+09	INFO	controllers.App	Added secret config to dex app instance.	{"app": "giantswarm/dex-app"}
1.6656579833364573e+09	INFO	controllers.App	Created default dex config secret for dex app instance.	{"app": "giantswarm/dex-app"}

The following config was added to the dex configuration using the mock connector:

  giantswarm:
    connectors:
    - connectorConfig:
        password: test
        username: test
      connectorName: Example
      connectorType: mockCallback
      id: mock

@anvddriesch anvddriesch marked this pull request as ready for review October 13, 2022 12:31
@anvddriesch anvddriesch requested a review from a team October 13, 2022 12:31
@anvddriesch anvddriesch merged commit d42a7bf into main Oct 17, 2022
@anvddriesch anvddriesch deleted the deploy branch October 17, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant