-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Review Ingress. #1995
Merged
Docs: Review Ingress. #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gacko
force-pushed
the
hgf4b
branch
2 times, most recently
from
November 23, 2023 17:18
2fcce63
to
2bdae98
Compare
mcharriere
reviewed
Nov 24, 2023
mcharriere
reviewed
Nov 24, 2023
src/content/advanced/connectivity/ingress/service-type-loadbalancer/index.md
Outdated
Show resolved
Hide resolved
…service.subdomain`.
…balancer-internal` a boolean.
…balancer-access-log-emit-interval` a string.
…al AWS Network Load Balancers.
…PROXY protocol and `externalTrafficPolicy: Local`.
…nternal AWS Network Load Balancers.
mcharriere
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR reviews and improves the documentation about Ingress (Ingress Controller Configuration, Multiple Ingress Controllers, Services).
What does it look like?
No relevant changes, only review.
Any background context you can provide?
Those pages have not been reviewed for a long time. Closes https://github.com/giantswarm/giantswarm/issues/26194.
What is needed from the reviewers?
Have you maintained the front matter?
No relevant changes, only review.