Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Review Ingress. #1995

Merged
merged 17 commits into from
Nov 28, 2023
Merged

Docs: Review Ingress. #1995

merged 17 commits into from
Nov 28, 2023

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Nov 23, 2023

What does this PR do?

This PR reviews and improves the documentation about Ingress (Ingress Controller Configuration, Multiple Ingress Controllers, Services).

What does it look like?

No relevant changes, only review.

Any background context you can provide?

Those pages have not been reviewed for a long time. Closes https://github.com/giantswarm/giantswarm/issues/26194.

What is needed from the reviewers?

Have you maintained the front matter?

No relevant changes, only review.

@Gacko Gacko changed the title Docs: Review Ingress Controller. Docs: Review Ingress. Nov 23, 2023
@Gacko Gacko requested a review from a team November 23, 2023 17:07
@Gacko Gacko marked this pull request as ready for review November 23, 2023 17:07
@Gacko Gacko requested a review from a team as a code owner November 23, 2023 17:07
@Gacko Gacko force-pushed the hgf4b branch 2 times, most recently from 2fcce63 to 2bdae98 Compare November 23, 2023 17:18
@Gacko Gacko self-assigned this Nov 24, 2023
@Gacko Gacko requested review from a team and mcharriere November 27, 2023 08:18
@Gacko Gacko enabled auto-merge (squash) November 27, 2023 08:18
@Gacko Gacko requested a review from LolloneS November 28, 2023 09:41
@Gacko Gacko merged commit 674cd4d into main Nov 28, 2023
5 checks passed
@Gacko Gacko deleted the hgf4b branch November 28, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants