Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for observability overview page #2203

Merged
merged 10 commits into from
Jun 6, 2024
Merged

Conversation

pipo02mix
Copy link
Contributor

@pipo02mix pipo02mix commented May 3, 2024

What this PR does / why we need it

Towards https://github.com/giantswarm/giantswarm/issues/30734

Things to check/remember before submitting

  • If you made content changes

    • Run make dev to render and proofread content changes locally.
    • Bump last_review_date in the front matter header if you reviewed the entire page.

@pipo02mix pipo02mix requested a review from a team as a code owner May 3, 2024 09:01
@QuentinBisson
Copy link
Contributor

@Rotfuks you probably want to check this out

@pipo02mix pipo02mix enabled auto-merge (squash) June 3, 2024 10:58
@QuentinBisson
Copy link
Contributor

I really like it overall but I'm wondering if we are not missing some important concepts like:

  • it's plug and play, you can add your own data, dashbaords and so on
  • that we eat our own dogfood (that we use it for ourselves for years)

Also, do we want to talk about the glue we make with our operators? And what about sloth? Maybe it's too specific :)

pipo02mix and others added 2 commits June 6, 2024 15:13
Co-authored-by: Hervé Nicol <hervenicol@users.noreply.github.com>
Co-authored-by: Quentin Bisson <quentin@giantswarm.io>
@pipo02mix
Copy link
Contributor Author

Comments reviewed. @QuentinBisson I have included some mention to cover that two bullet points since I consider you were right ;)

For the operators, I will leave for a more tech doc entry (maybe tutorial or getting started)

Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

@pipo02mix pipo02mix merged commit db6f003 into main Jun 6, 2024
8 checks passed
@pipo02mix pipo02mix deleted the add-overview-observability branch June 6, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants