Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic highlights #2207

Merged
merged 8 commits into from
Jul 17, 2024
Merged

Automatic highlights #2207

merged 8 commits into from
Jul 17, 2024

Conversation

pipo02mix
Copy link
Contributor

What this PR does / why we need it

Towards https://github.com/giantswarm/giantswarm/issues/30607

Things to check/remember before submitting

  • If you made content changes

    • Run make dev to render and proofread content changes locally.
    • Bump last_review_date in the front matter header if you reviewed the entire page.

@pipo02mix pipo02mix self-assigned this May 10, 2024
@pipo02mix pipo02mix marked this pull request as ready for review June 19, 2024 12:50
@pipo02mix pipo02mix requested a review from a team as a code owner June 19, 2024 12:50
@pipo02mix pipo02mix requested a review from weatherhog July 15, 2024 10:05
Copy link
Contributor

@weatherhog weatherhog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@pipo02mix
Copy link
Contributor Author

cool let's try it tomorrow. We can iterate over it

@pipo02mix pipo02mix enabled auto-merge (squash) July 17, 2024 08:33
@pipo02mix pipo02mix merged commit 9f8ec3c into main Jul 17, 2024
5 of 6 checks passed
@pipo02mix pipo02mix deleted the automatic-highlights branch July 17, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants