Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review workflow #2421

Merged
merged 28 commits into from
Dec 14, 2024
Merged

Review workflow #2421

merged 28 commits into from
Dec 14, 2024

Conversation

pipo02mix
Copy link
Contributor

What this PR does / why we need it

Towards https://github.com/giantswarm/giantswarm/issues/29503

Things to check/remember before submitting

  • If it's one of your first contributions, make sure you've read the Contributing Guidelines.
  • Bump last_review_date in the front matter header of the pages you've touched.

ally if it merges an updated upstream into a topic branch.
@pipo02mix pipo02mix requested a review from a team as a code owner December 13, 2024 11:02
@pipo02mix pipo02mix self-assigned this Dec 13, 2024
@pipo02mix pipo02mix enabled auto-merge (squash) December 13, 2024 12:37
Copy link
Member

@marians marians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine if it works for you

@@ -2,7 +2,7 @@ name: Generate review Issues weekly
on:
schedule:
# At 0:00 on Sundays
- cron: '0 0 * * 0'
- cron: '0 0 * * 0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change this to any other minute, we won't contribute as much to the typical cronjob load spike in cloud providers.

@pipo02mix pipo02mix merged commit 4652b2b into main Dec 14, 2024
8 checks passed
@pipo02mix pipo02mix deleted the review-workflow branch December 14, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants