-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: PDBs for all pods, require spread #2437
Conversation
Co-Authored-By: jonas@giantswarm.io <jonas@giantswarm.io>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
Hugo yielded some warnings. Please check whether they require action.
|
The error message from push-to-app-catalog is:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation error, otherwise looks fine.
Co-Authored-By: jonas@giantswarm.io <jonas@giantswarm.io>
Co-Authored-By: jonas@giantswarm.io <jonas@giantswarm.io>
Co-Authored-By: jonas@giantswarm.io <jonas@giantswarm.io>
Thank you! |
Where has the bot documented it? |
Documented what? The changes by this PR? I couldn't find a The changelog entries:
|
Devin initially wrote the CHANGELOG entries in two different places, even creating a new CHANGELOG.md for the repository. I told him this in one of the reviews: #2437 (comment)
|
Changes
This PR improves the high availability and deployment strategy of the docs deployment by:
Making pod anti-affinity required instead of preferred:
preferredDuringSchedulingIgnoredDuringExecution
torequiredDuringSchedulingIgnoredDuringExecution
Documenting existing PodDisruptionBudget (PDB) configuration:
minAvailable: 1
setting that ensures at least one replica is always availableAdding explicit RollingUpdate strategy:
maxSurge: 1
andmaxUnavailable: 1
Link to Devin run: https://app.devin.ai/sessions/9e6ed5a722aa40b1b3ca0844542981ca