More ingress-nginx renaming.
#4442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gacko
force-pushed
the
pull/4442
branch
2 times, most recently
from
c574ed5
to
75b1818
Compare
Gacko
force-pushed
the
pull/4442
branch
4 times, most recently
from
4c3a340
to
42ac4c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes more (or all left over?) occurrences of
nginxand/oringressrelated to Ingress NGINX Controller to match the new name.What is the effect of this change to users?
A consistent look & feel for everything related to Ingress NGINX Controller. :)
How does it look like?
Well, consistent. Hopefully. Several places where I changed it, can not supply screenshots for each and every of them.
Any background context you can provide?
The renaming of our
nginx-ingress-controller-appchart toingress-nginx.What is needed from the reviewers?
Do the docs need to be updated?
They are already updated, at least in
giantswarm/docsand other related repositories.Should this change be mentioned in the release notes?
If yes, please apply one of the following labels:
kind/feature,kind/change,kind/bug,kind/removal,kind/ux-enhancement,kind/security