add tenancy in self-service #261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
force-pushed
the
allow-setting-custom-tenant-on-pod
branch
2 times, most recently
from
da03311 to
eac9607
Compare
Open
2 tasks
Comment on lines
295
to
305
| tenant_id = env("{{ .TenantIDEnvVarName }}") | ||
| tenant_id = "giantswarm" |
There was a problem hiding this comment.
I liked the idea of using an env var to set the default tenant, why removing this ?
There was a problem hiding this comment.
What value does it bring?
QuentinBisson
force-pushed
the
write-all-to-giantswarm-tenant
branch
2 times, most recently
from
79a0d0c to
068c65f
Compare
QuentinBisson
commented
Dec 12, 2024
QuentinBisson
changed the base branch from
write-all-to-giantswarm-tenant
to
remove-mtp
QuentinBisson
force-pushed
the
allow-setting-custom-tenant-on-pod
branch
2 times, most recently
from
a4aef31 to
1985e10
Compare
* enable vpa on alloy-logs * Update pkg/resource/logging-config/alloy/logging-config.alloy.yaml.template * remove clutter
* enable vpa on alloy-logs * Update pkg/resource/logging-config/alloy/logging-config.alloy.yaml.template * remove clutter * add support-for-private-cas * disable grafana agent usage reporting * Update pkg/resource/logging-config/alloy-logging-config.go
* template grafana-agent-config * fix incorrect grafana agent secret namespace * add common format scraped namespaces
QuentinBisson
force-pushed
the
allow-setting-custom-tenant-on-pod
branch
from
1985e10 to
408b6f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR allows customers to set the tenant they want using the pod label
application_giantswarm_io_tenant.@TheoBrigitte do you have any ideas on how to test this?
Checklist