Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add promtail config template tests #271

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

QuentinBisson
Copy link
Contributor

@QuentinBisson QuentinBisson commented Nov 19, 2024

What this PR does / why we need it

Add some tests

Checklist

  • Update changelog in CHANGELOG.md.
  • Follow deployment test procedure in the tests/manual_e2e directory and have a working branch.

@QuentinBisson QuentinBisson self-assigned this Nov 19, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner November 19, 2024 19:40
@QuentinBisson QuentinBisson force-pushed the add-template-testing-for-promtail branch 2 times, most recently from 3ac55e3 to 107b612 Compare November 19, 2024 21:09
@QuantumEnigmaa
Copy link
Contributor

Did you run the tests to see if they're passing ?

@QuentinBisson
Copy link
Contributor Author

Tests run in CI so if tests fail then they will fail on my machine :)

@QuentinBisson QuentinBisson merged commit aa3af48 into main Nov 20, 2024
8 checks passed
@QuentinBisson QuentinBisson deleted the add-template-testing-for-promtail branch November 20, 2024 16:05
QuentinBisson added a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants