add tests for alloy-events in events-logger-config #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
TheoBrigitte
approved these changes
Nov 25, 2024
QuantumEnigmaa
added a commit
that referenced
this pull request
Nov 25, 2024
* add k8s events logging to alloy * changelog * create the events-logger resource : either alloy or grafana-agent * handle secret for authentication * fix alloy config property name * fix build errors * rename k8s-events-config package to events-logger-config * Apply suggestions from code review Co-authored-by: Quentin Bisson <quentin@giantswarm.io> * fix error log * return correct configmap name depending on the events logger * return correct secret name depending on the events logger * add scrapedNamespaces to alloy config create related function in common * add tls config for alloy * fix formating in grafana-agent template * hardcode controller.type and controller.replicas in alloyEvents template * remove unused observabilityBundleVersion parameters and variable in events-logger-config * remove grafanaAgentSecretName and eventsLoggerSecretName from security checking * rename variables in events-logger-config's reconciler to a neutral name * make several functions private * hardcode several fields in grafana-agent config template * rename comments and logs in agents-toggle's reconciler * enable events logger in main.go * fix formating in events-logger templates * remove unused field in alloy generateAlloyConfig * fix alloy-events secret name * Apply suggestions from code review Co-authored-by: Quentin Bisson <quentin@giantswarm.io> * update test files * handle specific case of observability-bundle version < 0.9.0 * remove secret namespace field * remove extra line in alloy and grafana-agent config * fix variable name in reconcileDelete method from event-logger-config reconciler * fix UTs for grafana-agent template * disable crds creation in alloy-events template * fixed grafana-agent tests in events-logger-config * fix enabling of events logger depending on observability-bundle version * minor fixes * add tests for alloy-events in events-logger-config (#277) * add tests for alloy-events in events-logger-config * changelog * create alloy-events tests golden files --------- Co-authored-by: Quentin Bisson <quentin@giantswarm.io>
QuentinBisson
added a commit
that referenced
this pull request
Dec 17, 2024
* add k8s events logging to alloy * changelog * create the events-logger resource : either alloy or grafana-agent * handle secret for authentication * fix alloy config property name * fix build errors * rename k8s-events-config package to events-logger-config * Apply suggestions from code review Co-authored-by: Quentin Bisson <quentin@giantswarm.io> * fix error log * return correct configmap name depending on the events logger * return correct secret name depending on the events logger * add scrapedNamespaces to alloy config create related function in common * add tls config for alloy * fix formating in grafana-agent template * hardcode controller.type and controller.replicas in alloyEvents template * remove unused observabilityBundleVersion parameters and variable in events-logger-config * remove grafanaAgentSecretName and eventsLoggerSecretName from security checking * rename variables in events-logger-config's reconciler to a neutral name * make several functions private * hardcode several fields in grafana-agent config template * rename comments and logs in agents-toggle's reconciler * enable events logger in main.go * fix formating in events-logger templates * remove unused field in alloy generateAlloyConfig * fix alloy-events secret name * Apply suggestions from code review Co-authored-by: Quentin Bisson <quentin@giantswarm.io> * update test files * handle specific case of observability-bundle version < 0.9.0 * remove secret namespace field * remove extra line in alloy and grafana-agent config * fix variable name in reconcileDelete method from event-logger-config reconciler * fix UTs for grafana-agent template * disable crds creation in alloy-events template * fixed grafana-agent tests in events-logger-config * fix enabling of events logger depending on observability-bundle version * minor fixes * add tests for alloy-events in events-logger-config (#277) * add tests for alloy-events in events-logger-config * changelog * create alloy-events tests golden files --------- Co-authored-by: Quentin Bisson <quentin@giantswarm.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Checklist