Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loki datasource on capi #278

Open
wants to merge 7 commits into
base: write-all-to-giantswarm-tenant
Choose a base branch
from

Conversation

QuentinBisson
Copy link
Contributor

What this PR does / why we need it

Towards giantswarm/roadmap#3726

This PR deletes the old datasource on CAPI MCs as it is now managed by olly-op.

This PR includes changed from #215

Checklist

  • Update changelog in CHANGELOG.md.
  • Follow deployment test procedure in the tests/manual_e2e directory and have a working branch.

@QuentinBisson QuentinBisson force-pushed the remove-loki-datasource-on-capi branch from d1c47d1 to 09639d7 Compare November 25, 2024 14:06
@QuentinBisson QuentinBisson changed the base branch from main to write-all-to-giantswarm-tenant November 25, 2024 14:06
@QuentinBisson QuentinBisson force-pushed the remove-loki-datasource-on-capi branch 3 times, most recently from 7e0ffc0 to ec5c003 Compare November 27, 2024 12:49
@QuentinBisson QuentinBisson force-pushed the write-all-to-giantswarm-tenant branch from 79a0d0c to 068c65f Compare November 27, 2024 14:47
@QuentinBisson QuentinBisson force-pushed the remove-loki-datasource-on-capi branch from ec5c003 to df4a0a5 Compare November 27, 2024 14:48
@QuentinBisson QuentinBisson force-pushed the remove-loki-datasource-on-capi branch from 27b0f51 to 6dae2e4 Compare December 17, 2024 16:17
Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants