generated from giantswarm/template-operator
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove loki datasource on capi #278
Open
QuentinBisson
wants to merge
7
commits into
write-all-to-giantswarm-tenant
Choose a base branch
from
remove-loki-datasource-on-capi
base: write-all-to-giantswarm-tenant
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove loki datasource on capi #278
QuentinBisson
wants to merge
7
commits into
write-all-to-giantswarm-tenant
from
remove-loki-datasource-on-capi
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
2 tasks
QuentinBisson
force-pushed
the
remove-loki-datasource-on-capi
branch
from
November 25, 2024 14:06
d1c47d1
to
09639d7
Compare
QuentinBisson
changed the base branch from
main
to
write-all-to-giantswarm-tenant
November 25, 2024 14:06
TheoBrigitte
approved these changes
Nov 25, 2024
QuentinBisson
force-pushed
the
remove-loki-datasource-on-capi
branch
3 times, most recently
from
November 27, 2024 12:49
7e0ffc0
to
ec5c003
Compare
QuentinBisson
force-pushed
the
write-all-to-giantswarm-tenant
branch
from
November 27, 2024 14:47
79a0d0c
to
068c65f
Compare
QuentinBisson
force-pushed
the
remove-loki-datasource-on-capi
branch
from
November 27, 2024 14:48
ec5c003
to
df4a0a5
Compare
QuentinBisson
force-pushed
the
remove-loki-datasource-on-capi
branch
from
December 17, 2024 16:17
27b0f51
to
6dae2e4
Compare
QuantumEnigmaa
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Towards giantswarm/roadmap#3726
This PR deletes the old datasource on CAPI MCs as it is now managed by olly-op.
This PR includes changed from #215
Checklist