Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logging-operator promtail-wiring that deleted WC user configs #45

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix logging-operator promtail-wiring that deleted WC user configs #45

merged 1 commit into from
Sep 28, 2023

Conversation

QuentinBisson
Copy link
Contributor

Ensure we do not delete userconfigs for workload clusters to fix https://github.com/giantswarm/giantswarm/issues/28257

@QuentinBisson QuentinBisson requested a review from a team as a code owner September 28, 2023 08:10
@QuentinBisson QuentinBisson self-assigned this Sep 28, 2023
QuantumEnigmaa
QuantumEnigmaa approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBisson QuentinBisson merged commit 2c7692b into main Sep 28, 2023
2 checks passed
@QuentinBisson QuentinBisson deleted the fix-promtail-wiring-controller-deletion branch September 28, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantumEnigmaa QuantumEnigmaa QuantumEnigmaa approved these changes

Assignees

@QuentinBisson QuentinBisson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuentinBisson @QuantumEnigmaa