Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capi support #62

Closed
wants to merge 16 commits into from
Closed

Add capi support #62

wants to merge 16 commits into from

Conversation

QuentinBisson
Copy link
Contributor

@QuentinBisson QuentinBisson commented Oct 18, 2023

This PR adds CAPI support to logging operator

@QuentinBisson QuentinBisson self-assigned this Oct 18, 2023
@QuentinBisson QuentinBisson force-pushed the add-capi-support branch 2 times, most recently from 3b2dcff to a79fb3f Compare October 18, 2023 22:02
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
@hervenicol
Copy link
Contributor

You have to differenciate MC from WCs, even on Capi, because the list of logs to retrieve differs.

I was wondering if that could be externalized in a config, so we can select which logs to retrieve for each clusters.
By default, we would have:

  • only select logs from kube-system and giantswarm namespaces
  • a custom configmap deployed via flux on all MCs (collections?) to retrieve all logs.

Not sure it's part of this PR though 😅

@QuentinBisson
Copy link
Contributor Author

The différentiation is actually done already in the promtail-config resource as we're using common.IsWorkloadCluster there :)

@QuentinBisson
Copy link
Contributor Author

@hervenicol this actually looks way better, but that means I have to test it everywhere :D

Signed-off-by: QuentinBisson <quentin@giantswarm.io>
pkg/common/common.go Outdated Show resolved Hide resolved
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
@QuentinBisson QuentinBisson marked this pull request as ready for review October 19, 2023 13:45
@QuentinBisson QuentinBisson requested a review from a team as a code owner October 19, 2023 13:45
@QuentinBisson QuentinBisson force-pushed the add-capi-support branch 3 times, most recently from 7fc933f to edafcf5 Compare October 31, 2023 14:07
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
@QuentinBisson QuentinBisson force-pushed the add-capi-support branch 22 times, most recently from 661c5bc to 1d9348d Compare November 2, 2023 09:46
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
@QuentinBisson
Copy link
Contributor Author

Dropping in favor of #81 and giantswarm/object-storage-operator#26

@QuentinBisson QuentinBisson deleted the add-capi-support branch July 9, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants