add manual e2e testing procedure #363
Conversation
Co-authored-by: Quentin Bisson <quentin@giantswarm.io>
Sure I can write something for that :) |
QuantumEnigmaa
force-pushed
the
add-manual-e2e-testing
branch
from
7abb46f to
bd6954f
Compare
|
@QuentinBisson I added a small script for checking essential requirements (app is deployed and loki-canary enabled) |
|
I tested it and it works :) |
QuantumEnigmaa
force-pushed
the
add-manual-e2e-testing
branch
from
40b507a to
8aaf67a
Compare
|
I also added a PR message template so that the user is invited to follow the testing procedure before asking for reviews. |
tests/manual_e2e/basic_checks.sh
Outdated
|
|
||
| deployed=$(kubectl get app -n giantswarm loki -o yaml | yq .status.release.status) | ||
|
|
||
| [[ "$deployed" != "deployed" ]] && exit_error "loki app is not in deployed state. Please fix the app before retrying" || echo "loki app is indeed in deployed state" |
There was a problem hiding this comment.
The || is useless: if the test matches, it will exit_error.
Also, most linters don't like too long lines.
So I suggest something like this:
| [[ "$deployed" != "deployed" ]] && exit_error "loki app is not in deployed state. Please fix the app before retrying" || echo "loki app is indeed in deployed state" | |
| [[ "$deployed" != "deployed" ]] \ | |
| && exit_error "loki app is not in deployed state. Please fix the app before retrying" | |
| echo "✔️ loki app is in deployed state" |
Which would apply to all tests then.
There was a problem hiding this comment.
Sure. As for the || this is just to keep logging updates on the advancement of the process. But if you think this isn't needed, I can get rid of those as well
There was a problem hiding this comment.
I didn't say the log message informing that the test passed successfully is useless.
I said the condition before it is useless.
My suggestion keeps the message, but removes the condition.
There was a problem hiding this comment.
Oh ok I get it
There was a problem hiding this comment.
@hervenicol I added back the messages without the condition
|
@hervenicol asking for your review again :) |
tests/manual_e2e/basic_checks.sh
Outdated
| deployed=$(kubectl get app -n giantswarm loki -o yaml | yq .status.release.status) | ||
|
|
||
| [[ "$deployed" != "deployed" ]] \ |
There was a problem hiding this comment.
| deployed=$(kubectl get app -n giantswarm loki -o yaml | yq .status.release.status) | |
| [[ "$deployed" != "deployed" ]] \ | |
| status=$(kubectl get app -n giantswarm loki -o yaml | yq .status.release.status) | |
| [[ "$status" != "deployed" ]] \ |
There was a problem hiding this comment.
Used appStatus to be even more precise :)
Towards giantswarm/roadmap#2008