move shared alert ownership to turtles #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
force-pushed
the
move-shared-component-alerts-to-turtles
branch
from
d6d4af9 to
05f1aef
Compare
weseven
approved these changes
Jun 6, 2024
TheoBrigitte
reviewed
Jun 6, 2024
| @@ -68,7 +68,7 @@ spec: | |||
| ) >= 6 | |||
| for: 10m | |||
| labels: | |||
| area: kaas | |||
| area: kaashelm/prometheus-rules/templates/shared/alerting-rules/net-exporter.rules.yml | |||
| groups: | ||
| - name: observability.storage | ||
| rules: | ||
| - alert: ObservabilityStorageSpaceTooLow |
There was a problem hiding this comment.
What is the reason for renaming from DataDiskPersistentVolumeSpaceTooLow and moving this alert from storage.management-cluster.rules.yml ?
There was a problem hiding this comment.
The renaming is not mandatory but the role was moved because storage.management-cluster.rules.yml belongs to turtle while this one belongs to atlas
There was a problem hiding this comment.
I can rename the alert if you prefer :)
There was a problem hiding this comment.
Oh right the alert moved under Atlas ownership, I missed that. Well fine with me then
2 tasks
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
QuentinBisson
force-pushed
the
move-shared-component-alerts-to-turtles
branch
from
ba82e6f to
68063d6
Compare
QuentinBisson
commented
Jun 10, 2024
helm/prometheus-rules/templates/shared/alerting-rules/node.workload_cluster.rules.yml
Outdated
Show resolved
Hide resolved
…kload_cluster.rules.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.
This PR moves alert ownership for shared components to turtles
Checklist
oncall-kaas-cloudGitHub group).