generated from giantswarm/template-app
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ops-recipe test script #1223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
@hervenicol I think I could use your eyes :) |
TheoBrigitte
approved these changes
Jun 7, 2024
{{- if eq .Values.managementCluster.provider.flavor "vintage" }} | ||
## TODO Remove with vintage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe explain when we should remove vintage, seems obvious but something like when all vintage installations are gone
I think that's what you mean here.
QuentinBisson
commented
Jun 9, 2024
helm/prometheus-rules/templates/kaas/phoenix/alerting-rules/calico.rules.yml
Outdated
Show resolved
Hide resolved
QuentinBisson
commented
Jun 9, 2024
helm/prometheus-rules/templates/kaas/phoenix/alerting-rules/cluster-service.rules.yml
Outdated
Show resolved
Hide resolved
…uster-service.rules.yml
QuentinBisson
commented
Jun 9, 2024
helm/prometheus-rules/templates/kaas/phoenix/alerting-rules/docker.rules.yml
Outdated
Show resolved
Hide resolved
QuentinBisson
commented
Jun 9, 2024
...metheus-rules/templates/kaas/phoenix/alerting-rules/inhibit.aws.management-cluster.rules.yml
Outdated
Show resolved
Hide resolved
…hibit.aws.management-cluster.rules.yml
QuentinBisson
commented
Jun 9, 2024
helm/prometheus-rules/templates/kaas/phoenix/alerting-rules/inhibit.kiam.rules.yml
Outdated
Show resolved
Hide resolved
…hibit.kiam.rules.yml
QuentinBisson
commented
Jun 9, 2024
helm/prometheus-rules/templates/kaas/phoenix/alerting-rules/vault.rules.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
QuentinBisson
force-pushed
the
fix-opsrecipe-test
branch
from
June 9, 2024 20:55
a47bd8e
to
14cfe0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.
Towards reenabling https://github.com/giantswarm/giantswarm/issues/23638
This PR fixes a few issues:
jq: error (at <stdin>:1): Cannot iterate over null (null)
. This fixes the templating by moving the comment after the helm templating.file cilium.rules.yml / alert: CiliumAPITooSlow / recipe: cilium/cilium-performance-issues - OK
Checklist
oncall-kaas-cloud
GitHub group).