Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ops-recipe test script #1223

Merged
merged 11 commits into from
Jun 9, 2024
Merged

Fix ops-recipe test script #1223

merged 11 commits into from
Jun 9, 2024

Conversation

QuentinBisson
Copy link
Contributor

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


Towards reenabling https://github.com/giantswarm/giantswarm/issues/23638

This PR fixes a few issues:

  • After some changes, some rules were rendered containing only comments and this caused issues when running the script jq: error (at <stdin>:1): Cannot iterate over null (null). This fixes the templating by moving the comment after the helm templating.
  • This PR also makes sure this script work with ops-recipes under things like cilium/cilium-performance-issues/_index.md. I have tested it with a small modification because the ciliumslow opsrecipe in in the dev-and-releng folder for some weird reasons but here is the output if after I've added the dev-and-releng to the list of ops-recipes:
    file cilium.rules.yml / alert: CiliumAPITooSlow / recipe: cilium/cilium-performance-issues - OK

Checklist

Signed-off-by: QuentinBisson <quentin@giantswarm.io>
@QuentinBisson QuentinBisson self-assigned this Jun 6, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner June 6, 2024 18:48
@QuentinBisson
Copy link
Contributor Author

@hervenicol I think I could use your eyes :)

{{- if eq .Values.managementCluster.provider.flavor "vintage" }}
## TODO Remove with vintage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe explain when we should remove vintage, seems obvious but something like when all vintage installations are gone I think that's what you mean here.

@QuentinBisson QuentinBisson merged commit 394ae9f into main Jun 9, 2024
7 checks passed
@QuentinBisson QuentinBisson deleted the fix-opsrecipe-test branch June 9, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants