Skip to content

Commit

Permalink
readline: clean up event listener in onNewListener
Browse files Browse the repository at this point in the history
Once the Readline interface is closed, the 'data' event listener should
be removed.

Refs: nodejs#9447 (comment)
  • Loading branch information
gibfahn committed May 28, 2017
1 parent 5b50501 commit 6d27376
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/readline.js
Original file line number Diff line number Diff line change
Expand Up @@ -1030,6 +1030,7 @@ function emitKeypressEvents(stream, iface) {
function onNewListener(event) {
if (event === 'keypress') {
stream.on('data', onData);
iface.once('close', () => { stream.removeListener('data', onData); });
stream.removeListener('newListener', onNewListener);
}
}
Expand Down

0 comments on commit 6d27376

Please sign in to comment.