Skip to content

Commit

Permalink
[prometheus-json-exporter] fix configmap name according to standard (p…
Browse files Browse the repository at this point in the history
…rometheus-community#3926)

Signed-off-by: t3mi <t3mi@users.noreply.github.com>
  • Loading branch information
t3mi authored and Matiasmct committed Mar 20, 2024
1 parent 5d1a1ac commit 28189ef
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/prometheus-json-exporter/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.7.3
version: 0.8.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
13 changes: 11 additions & 2 deletions charts/prometheus-json-exporter/README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# prometheus-json-exporter

Prometheus exporter for scraping JSON by JSONPath.

This chart bootstraps a [json_exporter](https://github.com/prometheus-community/json_exporter) deployment on a [Kubernetes](http://kubernetes.io) cluster using the [Helm](https://helm.sh) package manager.
Expand All @@ -8,22 +9,25 @@ This chart bootstraps a [json_exporter](https://github.com/prometheus-community/
- Kubernetes 1.10+ with Beta APIs enabled
- Helm 3+

## Get Repo Info
## Get Repository Info

```console
helm repo add prometheus-community https://prometheus-community.github.io/helm-charts
helm repo add stable https://charts.helm.sh/stable
helm repo update
```

<!-- textlint-disable -->
_See [helm repo](https://helm.sh/docs/helm/helm_repo/) for command documentation._
<!-- textlint-enable -->

## Install Chart

```console
# Helm
$ helm install [RELEASE_NAME] prometheus-community/prometheus-json-exporter
```

_See [configuration](## Configuring) below._

_See [helm install](https://helm.sh/docs/helm/helm_install/) for command documentation._
Expand All @@ -46,6 +50,11 @@ _See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall/) for command doc
$ helm upgrade [RELEASE_NAME] [CHART] --install
```

### From 0.7.x to 0.8.0

This version fixes configmap name according to the chart standard so that configmap will be recreated with subsequent deployment rollout.
See [#3926](https://github.com/prometheus-community/helm-charts/pull/3926) for more context.

## Configuring

See [Customizing the Chart Before Installing](https://helm.sh/docs/intro/using_helm/#customizing-the-chart-before-installing). To see all configurable options with detailed comments, visit the chart's [values.yaml](./values.yaml), or run these configuration commands:
Expand All @@ -55,4 +64,4 @@ See [Customizing the Chart Before Installing](https://helm.sh/docs/intro/using_h
$ helm show values prometheus-community/prometheus-json-exporter
```

For more information please refer to the [json_exporter](https://github.com/prometheus-community/json_exporter) documentation.
For more information please refer to the [json_exporter](https://github.com/prometheus-community/json_exporter) documentation.
2 changes: 1 addition & 1 deletion charts/prometheus-json-exporter/templates/configmap.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
kind: ConfigMap
metadata:
name: {{ .Release.Name }}-configmap
name: {{ include "prometheus-json-exporter.fullname" . }}
data:
allow-snippet-annotations: "false"
config.yml: |
Expand Down
2 changes: 1 addition & 1 deletion charts/prometheus-json-exporter/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ spec:
volumes:
- name: config-configmap-volume
configMap:
name: {{ .Release.Name }}-configmap
name: {{ include "prometheus-json-exporter.fullname" . }}
items:
- key: config.yml
path: config.yml
Expand Down

0 comments on commit 28189ef

Please sign in to comment.