Skip to content

Commit

Permalink
Remove Node.js 16
Browse files Browse the repository at this point in the history
Node.js 16 is no longer supported.
See https://nodejs.dev/en/about/releases/ for
more information
  • Loading branch information
giggio committed Sep 19, 2023
1 parent 0bb2212 commit 203e50c
Show file tree
Hide file tree
Showing 5 changed files with 82 additions and 66 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ RUN echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \
&& chmod 0440 /etc/sudoers.d/$USERNAME
USER $USERNAME
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.2/install.sh | bash
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm i --no-progress 16.20.0 && nvm i --no-progress 18.16.0 && nvm i --no-progress 20.2.0" ]
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm i --no-progress 18.18.0 && nvm i --no-progress 20.7.0" ]
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm alias default 20" ]
ENV DEBIAN_FRONTEND=dialog
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ["16.x", "18.x", "20.x"]
node: ["18.x", "20.x"]
runner: ["windows-latest", "ubuntu-latest", "macos-latest"]
steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ["16", "18", "20"]
node: ["18", "20"]
steps:
- uses: actions/checkout@v2
- uses: uraimo/run-on-arch-action@v2.1.1
Expand Down Expand Up @@ -109,14 +109,14 @@ jobs:
echo "Binary not found at $BIN"
exit 1
fi
build_s390x:
name: Build s390x
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node: ["16", "18", "20"]
node: ["18", "20"]
steps:
- uses: actions/checkout@v2
- uses: uraimo/run-on-arch-action@v2.1.1
Expand Down
134 changes: 75 additions & 59 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@
"typescript": "^5.1.6"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion testInstall.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const os = require('os');
const path = require('path');
const fs = require('fs');
const spawnSync = require('child_process').spawnSync;
const versions = ['16', '18', '20'];
const versions = ['18', '20'];
const tempInstallPath = path.resolve(os.tmpdir(), 'chromedriver-test');
const packedFile = path.resolve(tempInstallPath, 'chromedriver.tgz');

Expand Down

0 comments on commit 203e50c

Please sign in to comment.