build Dual CommonJS/ES module package #605
Merged
+677
−477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ES module loader in browser, Node and bundlers – e.g.
import {Maybe} from 'purify-ts/Maybe.js'
import {Maybe} from 'purify-ts/Maybe'
(requires import-map in browsers)import("purify-ts/Maybe").then(m => { globalThis.Maybe = m.Maybe; });
@rollup/plugin-node-resolve
CommonJS support should be untouched
node -e 'const Maybe = require("purify-ts").Maybe; console.log(Maybe.of("foo").orDefault("bar"));'
-->
"foo"
Two additional dev-dependencies
Unfortunately the TypeScript compiler still generates bare import specifiers in the js files. Many ways to "Provide a way to add the '.js' file extension to the end of module specifiers" are available to the JS community.
I choose the compiler plugin because both dependencies are themselves dependency-free – so less of a hassle to keep them up-to-date.