Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support keyPrefix #264

Merged
merged 3 commits into from
Dec 30, 2023
Merged

Support keyPrefix #264

merged 3 commits into from
Dec 30, 2023

Conversation

BorisTB
Copy link
Contributor

@BorisTB BorisTB commented Dec 4, 2023 •
edited
Loading

gilbsgilbs
gilbsgilbs requested changes Dec 5, 2023
View reviewed changes
Copy link
Owner

@gilbsgilbs gilbsgilbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting contribution, thank you 👍. Nice tests also.

Just have a few minor remarks that may or may not require change on your end.

src/keys.ts Outdated Show resolved Hide resolved
src/keys.ts Outdated Show resolved Hide resolved
src/keys.ts Outdated Show resolved Hide resolved
src/keys.ts Outdated Show resolved Hide resolved
@BorisTB
review fixes
59fd6fb 
- move keyPrefix to parsedOptions
- don't let user know he's about to break translations
@BorisTB
Copy link
Contributor Author

BorisTB commented Dec 18, 2023

PR updated

@gilbsgilbs gilbsgilbs merged commit 8b303a6 into gilbsgilbs:master Dec 30, 2023
7 of 8 checks passed
@gilbsgilbs
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilbsgilbs gilbsgilbs gilbsgilbs requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature key prefixes
2 participants
@BorisTB @gilbsgilbs