support for error messages #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osdiab
force-pushed
the
osdiab/error-messages
branch
from
57f0b2a
to
8a84182
Compare
|
refactored, ready to go |
|
@osdiab this needs merge conflicts resolving as well |
|
it doesn't show any merge conflicts with master? @gillchristian |
|
There were conflicts for rebasing and merging, but squash and merge worked :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24 , also removes the trailing period for the provided value (i think it doesn't help/the period can hurt clarity).
built on top of #20 so there's noise in the diff, here are the changes without that: https://github.com/OliverJAsh/io-ts-reporters/pull/25/files/39716c36ea5205155c0ba7117a5218940d90d983..57f0b2ae54130cd428cfd634978add1bfe983e9dI rebased to make it based on master.
Example output at https://github.com/OliverJAsh/io-ts-reporters/pull/25/files#diff-e1b1ef74bf2611df9cd1e2173b684deeR85