Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS Broken? #4

Closed
dramalho opened this issue Nov 27, 2014 · 7 comments
Closed

SCSS Broken? #4

dramalho opened this issue Nov 27, 2014 · 7 comments

Comments

@dramalho
Copy link

sass --check /usr/local/opt/rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/rails-assets-andy-1.0.1/app/assets/stylesheets/andy.scss
Error: Invalid CSS after "...ratio: $ratio),": expected media query (e.g. print, screen, print and screen), was "@media only scr..."
        on line 219 of /usr/local/opt/rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/rails-assets-andy-1.0.1/app/assets/stylesheets/andy/andy.scss
        from line 1 of /usr/local/opt/rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/rails-assets-andy-1.0.1/app/assets/stylesheets/andy.scss
  Use --trace for backtrace.

Pulling the raw file from github has the same issue. Am I doing something wrong?

@gillesbertaux
Copy link
Owner

Hm, go ahead and try, there was a small typo on l.219 probably from last merge, I pushed back to master. Let me know if it works now.

@gillesbertaux
Copy link
Owner

Oops another typo a few lines below from same merge. Sorry for that. Try again?

@dramalho
Copy link
Author

humm no, weird - not that I'm a big sass expert. It works fine with either

@media only screen and (max-width: $width) and (min--moz-device-pixel-ratio: $ratio)

or

@media only screen and (max-width: $width) and (-webkit-min-device-pixel-ratio: $ratio)

by themselves, but not with the comma.

Sorry to be bothering :)

@gillesbertaux
Copy link
Owner

Ok, just pushed some changes. Compiling fine here, what about you?

@dramalho
Copy link
Author

Perfect :)

new tag, for the sake of rails-assets?

Cheers Gilles

@gillesbertaux
Copy link
Owner

Great! Good catch ;) :shipit:

Yep!

@dramalho
Copy link
Author

awesome stuff, thanks Gilles


David Ramalho - @dramalho

On Thu, Nov 27, 2014 at 11:30 PM, Gilles Bertaux notifications@github.com
wrote:

Great! Good catch ;) :shipit:

Yep!

Reply to this email directly or view it on GitHub:
#4 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants