Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to indexmap 2? #665

Closed
cuviper opened this issue Jul 7, 2023 · 2 comments · Fixed by #672
Closed

Upgrade to indexmap 2? #665

cuviper opened this issue Jul 7, 2023 · 2 comments · Fixed by #672

Comments

@cuviper
Copy link

cuviper commented Jul 7, 2023

I would be happy to send a PR upgrading to indexmap 2, and it doesn't even require any code changes, but it would increase the MSRV enough that I'm not sure it would be welcome.

It would require 1.64 when feature write = ["indexmap"] is enabled, and at least 1.60 otherwise due to hashbrown's use of new dependency syntax. I don't know if you want to bother with split MSRV, but I also described this in gimli-rs/object#558.
@philipc
Copy link
Collaborator

philipc commented Jul 10, 2023

The MSRV in this crate is a bit of a mess currently, so I'll take care of this next time I'm doing a release, unless you have a need for it now.

@cuviper
Copy link
Author

cuviper commented Jul 10, 2023

I have no strong need here -- just trying to help upgrade the ecosystem to reduce duplicate dependencies.

@philipc philipc mentioned this issue Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dependencies philipc/gimli
2 participants
@cuviper @philipc