Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to hashbrown 0.14 and indexmap 2 #558

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

cuviper
Copy link
Contributor

@cuviper cuviper commented Jul 7, 2023

This doesn't need any code changes, but it does increase the MSRV.

  • The base "read" MSRV is now 1.60, because hashbrown's use of the newer dependency syntax makes it invisible to older Cargo, which makes it un-resolvable even when hashbrown isn't feature-enabled.
    • I also took this opportunity to use the dep: syntax here, so hashbrown and indexmap don't show up as explicit features of object anymore. Maybe other optional dependencies could use this too.
  • The "write" MSRV is now 1.64 to match the actual required versions of these new hashbrown and indexmap.

@cuviper
Copy link
Contributor Author

cuviper commented Jul 7, 2023

which makes it un-resolvable even when hashbrown isn't feature-enabled.

Actually, I think this is only because the lockfile reflects all possible features. If you test from a separate workspace, it can live without resolving hashbrown, like serde_json did here:
serde-rs/json@d4c98d0

@philipc
Copy link
Contributor

philipc commented Jul 8, 2023

Split MSRV is fine, but I'm not sure about bumping to 1.60 yet.

Does testing from a separate workspace only help for tests that are in a separate crate?

@cuviper
Copy link
Contributor Author

cuviper commented Jul 8, 2023

It does work if I use a new crate with a path dependency, use only --features read,std, then cargo +1.52.0 test -p object. Let me see if I can put that to use in CI...

@cuviper
Copy link
Contributor Author

cuviper commented Jul 8, 2023

Seems to work locally, but we'll see when you push that CI button. :)

@philipc
Copy link
Contributor

philipc commented Jul 10, 2023

Ah, I didn't know you could run tests for another package like that. Unfortunately it only works when there are no dev dependencies, so we can't do this for the tests in crates/examples as well. I think this is too much of a hack and we should just bump to 1.60 instead.

@cuviper
Copy link
Contributor Author

cuviper commented Jul 10, 2023

Okay, I've reset this back to how I had it before.

@philipc philipc merged commit 7806cbf into gimli-rs:master Jul 29, 2023
mcbegamerxx954 pushed a commit to mcbegamerxx954/object that referenced this pull request Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants