Add ability to parse pdb info from PE file #298
Conversation
Just like we can get the UUID from macho files and the build-id from ELF files, this change allows users to pull out the PDB info (path, age, and GUID) from PE files. macho and ELF files will return `Ok(None)`
src/read/mod.rs
Outdated
| /// PDB Information | ||
| #[derive(Debug, Clone, Copy, PartialEq, Eq)] | ||
| pub struct CodeView<'data> { | ||
| guid: Bytes<'data>, |
There was a problem hiding this comment.
Should this be [u8; 16]?
I also considered the existing pe::Guid but I don't think its definition is great. Maybe it should be [u8; 16] too.
There was a problem hiding this comment.
Yea, I think [u8; 16] makes sense. I believe the definition of the GUID is well defined as 16 bytes. According to Microsoft's definition at least. I'll change to [u8; 16].
I also considered the existing
pe::Guid
Oh woah, I did not see this on my first pass. I'm happy to use pe::Guid or convert pe::Guid to be a [u8; 16]. The technical definition from Microsoft's definition is what is currently defined for pe::Guid. I'm happy to use that.
Fix comment that does not make sense. Co-authored-by: Philip Craig <philipjcraig@gmail.com>
Co-authored-by: Philip Craig <philipjcraig@gmail.com>
src/read/mod.rs
Outdated
| /// PDB Information | ||
| #[derive(Debug, Clone, Copy, PartialEq, Eq)] | ||
| pub struct CodeView<'data> { | ||
| guid: &'data [u8; 16], |
There was a problem hiding this comment.
Let's change it from a reference to a value too, the size of this struct isn't significant.
There was a problem hiding this comment.
I can definitely do that, but I'm curious what benefit this brings? The path value will still need to be a reference with a lifetime of 'data unless we want to copy that as well meaning this struct will still need to have the 'data lifetime.
There was a problem hiding this comment.
For consistency with mach_uuid, and for the incredibly minor benefit that the user doesn't need to dereference it. I think UUIDs are like a primitive type that you normally pass around by value, not by reference. e.g. if we were reading a u128, then you'd probably expect that to be passed by value.
There was a problem hiding this comment.
Makes sense, thanks for the explanation!
Co-authored-by: Philip Craig <philipjcraig@gmail.com>
Just like we can get the UUID from macho files and the build-id from ELF files, this change allows users to pull out the PDB info (path, age, and GUID) from PE files. macho and ELF files will return `Ok(None)`
Just like we can get the UUID from macho files and the build-id from ELF
files, this change allows users to pull out the PDB info (path, age, and
GUID) from PE files.
macho and ELF files will return
Ok(None)