-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for x86_32 architecture #320
Conversation
x32 may be dropped from the Linux kernel in the future: https://lkml.org/lkml/2018/12/10/1145 |
I prefer if the minimum support added is enough to pass the test at object/tests/round_trip/mod.rs Line 229 in 55a50c8
|
This corresponds to the Rust `x86_64-unknown-linux-gnux32` target, notably that the architecture listed is x86_64 but the word size is 32
Certainly! Some small testing locally appeared that relocations for x86_32 are encoded in the same way as x86_64, although I am not certain about this. Do you know of a location to confirm that? |
LLVM agrees with that: https://github.com/llvm/llvm-project/blob/e712a92b8fe706c4a736748af324382850d1515c/llvm/lib/Target/X86/MCTargetDesc/X86ELFObjectWriter.cpp#L334-L339 Also, I'm not sure that x86_32 is the correct name for this; to me, that is the same as i386. I've seen this referred to as x32, |
Yeah I seem to see a lot of various names, but presumably keeping "x32" somewhere in the name is most reasonable? Maybe |
Let's go with |
Sounds good! Pushed up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This corresponds to the Rust `x86_64-unknown-linux-gnux32` target, notably that the architecture listed is x86_64 but the word size is 32
This corresponds to the Rust
x86_64-unknown-linux-gnux32
target,notably that the architecture listed is x86_64 but the word size is 32