Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write/xcoff: add support. #482

Merged
merged 15 commits into from
Mar 27, 2023
Merged

write/xcoff: add support. #482

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6a75fda
write/xcoff: add support.
EsmeYi Nov 7, 2022
65b2fe9
Address comments and add support for the auxiliary symbol.
EsmeYi Dec 20, 2022
f23311c
Address comments.
EsmeYi Jan 5, 2023
c2c4a0d
Address comments (adjust the storage_class).
EsmeYi Feb 8, 2023
1fced0e
Modify SymbolFlags::Xcoff.
EsmeYi Feb 8, 2023
355d7c8
Revert "Modify SymbolFlags::Xcoff."
EsmeYi Feb 8, 2023
606117b
Modify SymbolFlags::Xcoff
EsmeYi Feb 8, 2023
b608c46
1. add cfg feature for test.
EsmeYi Feb 22, 2023
a217b49
Merge branch 'master' into xcoff_write
EsmeYi Feb 22, 2023
36ddbe0
Rebase.
EsmeYi Feb 22, 2023
4228f1f
Update the test result.
EsmeYi Feb 23, 2023
734e77d
Generate auxiliary entry according to the type of storage_class.
EsmeYi Mar 22, 2023
b37ffb3
fmt.
EsmeYi Mar 22, 2023
452574d
Symbols without section may have auxiliary entry.
EsmeYi Mar 23, 2023
272622f
fmt
EsmeYi Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "object"
version = "0.30.3"
edition = "2018"
exclude = ["/.github", "/testfiles"]
keywords = ["object", "elf", "mach-o", "pe", "coff"]
keywords = ["object", "elf", "mach-o", "pe", "coff", "xcoff"]
license = "Apache-2.0 OR MIT"
repository = "https://github.com/gimli-rs/object"
description = "A unified interface for reading and writing object file formats."
Expand Down
18 changes: 9 additions & 9 deletions crates/examples/testfiles/xcoff/base.o.objdump
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ Entry Address: 0
1: Section { name: ".data", address: 68, size: 20, align: 4, kind: Data, flags: Xcoff { s_flags: 40 } }

Symbols
0: Symbol { name: ".file", address: 0, size: 0, kind: File, section: None, scope: Compilation, weak: false, flags: None }
3: Symbol { name: ".printf", address: 0, size: 0, kind: Unknown, section: Undefined, scope: Unknown, weak: false, flags: None }
5: Symbol { name: "printf", address: 0, size: 0, kind: Unknown, section: Undefined, scope: Unknown, weak: false, flags: None }
7: Symbol { name: ".text", address: 0, size: 57, kind: Text, section: Section(SectionIndex(1)), scope: Dynamic, weak: false, flags: None }
9: Symbol { name: ".main", address: 0, size: 0, kind: Text, section: Section(SectionIndex(1)), scope: Dynamic, weak: false, flags: None }
11: Symbol { name: ".rodata.str1.1L...str", address: 58, size: d, kind: Text, section: Section(SectionIndex(1)), scope: Dynamic, weak: false, flags: None }
13: Symbol { name: "main", address: 68, size: 18, kind: Data, section: Section(SectionIndex(2)), scope: Dynamic, weak: false, flags: None }
15: Symbol { name: "TOC", address: 80, size: 0, kind: Data, section: Section(SectionIndex(2)), scope: Dynamic, weak: false, flags: None }
17: Symbol { name: ".rodata.str1.1L...str", address: 80, size: 8, kind: Data, section: Section(SectionIndex(2)), scope: Dynamic, weak: false, flags: None }
0: Symbol { name: ".file", address: 0, size: 0, kind: File, section: None, scope: Compilation, weak: false, flags: Xcoff { n_sclass: 67 } }
3: Symbol { name: ".printf", address: 0, size: 0, kind: Section, section: Undefined, scope: Unknown, weak: false, flags: Xcoff { n_sclass: 2 } }
5: Symbol { name: "printf", address: 0, size: 0, kind: Section, section: Undefined, scope: Unknown, weak: false, flags: Xcoff { n_sclass: 2 } }
7: Symbol { name: ".text", address: 0, size: 57, kind: Section, section: Section(SectionIndex(1)), scope: Dynamic, weak: false, flags: Xcoff { n_sclass: 6b } }
9: Symbol { name: ".main", address: 0, size: 0, kind: Section, section: Section(SectionIndex(1)), scope: Dynamic, weak: false, flags: Xcoff { n_sclass: 2 } }
11: Symbol { name: ".rodata.str1.1L...str", address: 58, size: d, kind: Section, section: Section(SectionIndex(1)), scope: Dynamic, weak: false, flags: Xcoff { n_sclass: 6b } }
13: Symbol { name: "main", address: 68, size: 18, kind: Section, section: Section(SectionIndex(2)), scope: Dynamic, weak: false, flags: Xcoff { n_sclass: 2 } }
15: Symbol { name: "TOC", address: 80, size: 0, kind: Section, section: Section(SectionIndex(2)), scope: Dynamic, weak: false, flags: Xcoff { n_sclass: 6b } }
17: Symbol { name: ".rodata.str1.1L...str", address: 80, size: 8, kind: Section, section: Section(SectionIndex(2)), scope: Dynamic, weak: false, flags: Xcoff { n_sclass: 6b } }
philipc marked this conversation as resolved.
Show resolved Hide resolved

.text relocations
(1e, Relocation { kind: Got, encoding: Generic, size: 10, target: Symbol(SymbolIndex(11)), addend: 0, implicit_addend: true })
Expand Down
158 changes: 79 additions & 79 deletions crates/examples/testfiles/xcoff/base.xcoff.objdump
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions crates/examples/testfiles/xcoff/base32.o.objdump
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ Entry Address: 0
1: Section { name: ".data", address: 6c, size: 10, align: 4, kind: Data, flags: Xcoff { s_flags: 40 } }

Symbols
0: Symbol { name: ".file", address: 0, size: 0, kind: File, section: None, scope: Compilation, weak: false, flags: None }
3: Symbol { name: ".printf", address: 0, size: 0, kind: Unknown, section: Undefined, scope: Unknown, weak: false, flags: None }
5: Symbol { name: "printf", address: 0, size: 0, kind: Unknown, section: Undefined, scope: Unknown, weak: false, flags: None }
7: Symbol { name: ".text", address: 0, size: 5b, kind: Text, section: Section(SectionIndex(1)), scope: Dynamic, weak: false, flags: None }
9: Symbol { name: ".main", address: 0, size: 0, kind: Text, section: Section(SectionIndex(1)), scope: Dynamic, weak: false, flags: None }
11: Symbol { name: ".rodata.str1.1L...str", address: 5c, size: d, kind: Text, section: Section(SectionIndex(1)), scope: Dynamic, weak: false, flags: None }
13: Symbol { name: "main", address: 6c, size: c, kind: Data, section: Section(SectionIndex(2)), scope: Dynamic, weak: false, flags: None }
15: Symbol { name: "TOC", address: 78, size: 0, kind: Data, section: Section(SectionIndex(2)), scope: Dynamic, weak: false, flags: None }
17: Symbol { name: ".rodata.str1.1L...str", address: 78, size: 4, kind: Data, section: Section(SectionIndex(2)), scope: Dynamic, weak: false, flags: None }
0: Symbol { name: ".file", address: 0, size: 0, kind: File, section: None, scope: Compilation, weak: false, flags: Xcoff { n_sclass: 67 } }
3: Symbol { name: ".printf", address: 0, size: 0, kind: Section, section: Undefined, scope: Unknown, weak: false, flags: Xcoff { n_sclass: 2 } }
5: Symbol { name: "printf", address: 0, size: 0, kind: Section, section: Undefined, scope: Unknown, weak: false, flags: Xcoff { n_sclass: 2 } }
7: Symbol { name: ".text", address: 0, size: 5b, kind: Section, section: Section(SectionIndex(1)), scope: Dynamic, weak: false, flags: Xcoff { n_sclass: 6b } }
9: Symbol { name: ".main", address: 0, size: 0, kind: Section, section: Section(SectionIndex(1)), scope: Dynamic, weak: false, flags: Xcoff { n_sclass: 2 } }
11: Symbol { name: ".rodata.str1.1L...str", address: 5c, size: d, kind: Section, section: Section(SectionIndex(1)), scope: Dynamic, weak: false, flags: Xcoff { n_sclass: 6b } }
13: Symbol { name: "main", address: 6c, size: c, kind: Section, section: Section(SectionIndex(2)), scope: Dynamic, weak: false, flags: Xcoff { n_sclass: 2 } }
15: Symbol { name: "TOC", address: 78, size: 0, kind: Section, section: Section(SectionIndex(2)), scope: Dynamic, weak: false, flags: Xcoff { n_sclass: 6b } }
17: Symbol { name: ".rodata.str1.1L...str", address: 78, size: 4, kind: Section, section: Section(SectionIndex(2)), scope: Dynamic, weak: false, flags: Xcoff { n_sclass: 6b } }

.text relocations
(22, Relocation { kind: Got, encoding: Generic, size: 10, target: Symbol(SymbolIndex(11)), addend: 0, implicit_addend: true })
Expand Down
Loading