Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for uncompressed data #723

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

marxin
Copy link
Contributor

@marxin marxin commented Aug 27, 2024

The PR verifies that the uncompressed data matches the declared size in the compression section header.

Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you encounter a file this occurs for?

src/read/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Philip Craig <philipjcraig@gmail.com>
@marxin
Copy link
Contributor Author

marxin commented Aug 27, 2024

No, but I was surprised it was not reported when I wrote a unit test for CompressedData::decompress.

Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipc philipc merged commit 9c0b256 into gimli-rs:master Aug 27, 2024
10 checks passed
@marxin marxin deleted the check-uncompressed-size branch August 27, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants