Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(zap): replace otel trace ID with custom fields. #46

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Conversation

appleboy
Copy link
Member

See the readme and example.

ref: #36

cc @udhos

@codecov-commenter
Copy link

Codecov Report

Merging #46 (cad05be) into master (9334b16) will increase coverage by 1.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   39.32%   40.69%   +1.37%     
==========================================
  Files           1        1              
  Lines          89       86       -3     
==========================================
  Hits           35       35              
+ Misses         51       49       -2     
+ Partials        3        2       -1     
Flag Coverage Δ
go- 40.69% <ø> (+1.37%) ⬆️
go-1.16 40.69% <ø> (+1.37%) ⬆️
go-1.17 40.69% <ø> (+1.37%) ⬆️
go-1.18 40.69% <ø> (+1.37%) ⬆️
go-1.19 40.69% <ø> (+1.37%) ⬆️
macos-latest 40.69% <ø> (+1.37%) ⬆️
ubuntu-latest 40.69% <ø> (+1.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
zap.go 40.69% <ø> (+1.37%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@appleboy appleboy merged commit fe995df into master Sep 16, 2022
@appleboy appleboy deleted the fields2 branch September 16, 2022 01:44
silvestre added a commit to cloudfoundry/app-autoscaler-release that referenced this pull request Oct 6, 2023
silvestre added a commit to cloudfoundry/app-autoscaler-release that referenced this pull request Oct 6, 2023
silvestre added a commit to cloudfoundry/app-autoscaler-release that referenced this pull request Oct 6, 2023
silvestre added a commit to cloudfoundry/app-autoscaler-release that referenced this pull request Oct 6, 2023
app-autoscaler-ci-bot pushed a commit to cloudfoundry/app-autoscaler-release that referenced this pull request Oct 6, 2023
* fix(deps): update module github.com/gin-contrib/zap to v0.2.0

* 🦾🛠️ go mod tidy & make package-specs

* chore(zap): replace otel trace ID with custom fields

see gin-contrib/zap#46

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Silvestre Zabala <silvestre.zabala@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants