Make "" mode being the same as debug mode #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1250 +/- ##
=========================================
+ Coverage 98.4% 98.4% +<.01%
=========================================
Files 34 34
Lines 1757 1759 +2
=========================================
+ Hits 1729 1731 +2
Misses 23 23
Partials 5 5
Continue to review full report at Codecov.
|
appleboy
requested changes
Feb 22, 2018
mode.go
Outdated
| case "": | ||
| ginMode = debugCode | ||
| value = DebugMode | ||
| case DebugMode: |
There was a problem hiding this comment.
revert this part and add the following code.
find
modeName = value
add before
if value == "" {
value = DebugMode
}
modeName = value
Not setting mode explicitly sets gin into debug mode, but it does not make it possible to retrieve gin mode as Debug since it's set to "".
mariokostelac
force-pushed
the
mario/debug_mode
branch
from
34ca522
to
3dae84f
Compare
appleboy
approved these changes
Feb 23, 2018
tonyhhyip
pushed a commit
to ysitd-cloud/gin
that referenced
this pull request
Apr 28, 2018
Not setting mode explicitly sets gin into debug mode, but it does not make it possible to retrieve gin mode as Debug since it's set to "". (cherry picked from commit 5d3f30c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not setting mode explicitly sets gin into debug mode, but it does not
make it possible to retrieve gin mode as Debug since it's set to "".
Calling
gin.Mode()returns "" even though gin is in debug mode.The alternative approach is to change SetMode to not accept "" and make
initfunction callingSetMode(DebugMode)explicitly when the mode is not defined. That would definitely change how SetMode reacts to inputs and could break some apps.