-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace debug log with fmt package. #1560
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1560 +/- ##
==========================================
- Coverage 99.06% 99.05% -0.01%
==========================================
Files 39 39
Lines 1915 1913 -2
==========================================
- Hits 1897 1895 -2
Misses 14 14
Partials 4 4
Continue to review full report at Codecov.
|
4 similar comments
Codecov Report
@@ Coverage Diff @@
## master #1560 +/- ##
==========================================
- Coverage 99.06% 99.05% -0.01%
==========================================
Files 39 39
Lines 1915 1913 -2
==========================================
- Hits 1897 1895 -2
Misses 14 14
Partials 4 4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1560 +/- ##
==========================================
- Coverage 99.06% 99.05% -0.01%
==========================================
Files 39 39
Lines 1915 1913 -2
==========================================
- Hits 1897 1895 -2
Misses 14 14
Partials 4 4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1560 +/- ##
==========================================
- Coverage 99.06% 99.05% -0.01%
==========================================
Files 39 39
Lines 1915 1913 -2
==========================================
- Hits 1897 1895 -2
Misses 14 14
Partials 4 4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1560 +/- ##
==========================================
- Coverage 99.06% 99.05% -0.01%
==========================================
Files 39 39
Lines 1915 1913 -2
==========================================
- Hits 1897 1895 -2
Misses 14 14
Partials 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@appleboy This leads to logging to stdout instead of stderr, right? That would be a big change. Is this wanted? |
@philippgille just change the output from |
@appleboy: Yes I saw that, that's exactly what I mean. Some people might in the past have piped stderr into file x and stdout into file y, now when updating gin the files don't contain their expected logs anymore, which is why it's a breaking change. For access logs stdout makes sense. For errors, stderr might be a better fit. And users should be made aware of the change in Gin. |
@thinkerou what do you think about the change of general logging from stderr to stdout? |
Hey @appleboy, this change is breaking App Engine local development server to work properly. Is possible to revert to use the log instead of fmt ? thanks |
@giulianobr @philippgille Please help to review the new PR. #1571 |
fix #1560 changes are breaking in App Engine. cc @giulianobr @philippgille
@philippgille #1571 already merged. |
fix gin-gonic#1560 changes are breaking in App Engine. cc @giulianobr @philippgille
fix #829
remove
log.SetFlags(0)