Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router: Route StaticFS() not found to Router's NoRoute() #1663

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Router: Route StaticFS() not found to Router's NoRoute() #1663

merged 2 commits into from
Nov 26, 2018

Conversation

ilijaivanov
Copy link
Contributor

Closes #1220

@codecov
Copy link

codecov bot commented Nov 25, 2018 •
edited
Loading

Codecov Report

Merging #1663 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
+ Coverage   99.39%   99.39%   +<.01%     
==========================================
  Files          41       41              
  Lines        1990     1993       +3     
==========================================
+ Hits         1978     1981       +3     
  Misses          9        9              
  Partials        3        3
Impacted Files Coverage Δ
routergroup.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 149ef75...b9be444. Read the comment docs.

@thinkerou thinkerou added this to the 1.4 milestone Nov 26, 2018
@ilijaivanov
Copy link
Contributor Author

Made it automergeable now. Thanks for reviewing :)

@appleboy appleboy merged commit b97ccf3 into gin-gonic:master Nov 26, 2018
@thinkerou thinkerou mentioned this pull request Nov 26, 2018
Closed
@thinkerou thinkerou mentioned this pull request Dec 26, 2018
Closed
@sairoutine sairoutine mentioned this pull request Mar 10, 2019
Closed
@ryanlaws ryanlaws mentioned this pull request Oct 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkerou thinkerou thinkerou approved these changes

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ilijaivanov @appleboy @thinkerou