Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix test fail #1669

Merged
merged 4 commits into from
Dec 4, 2018
Merged

chore: fix test fail #1669

merged 4 commits into from
Dec 4, 2018

Conversation

thinkerou
Copy link
Member

@thinkerou thinkerou commented Nov 26, 2018

now ci have the following output:

[GIN-debug] GET    /recovery                 --> github.com/gin-gonic/gin.TestPanicWithBrokenPipe.func1.1 (2 handlers)
--- FAIL: TestPanicWithBrokenPipe (0.00s)
    --- FAIL: TestPanicWithBrokenPipe/Broken_pipe (0.00s)
        recovery_test.go:111: 
            	Error Trace:	recovery_test.go:111
            	Error:      	"
            	            	
            	            	2018/11/26 03:31:54 : : broken pipe
            	            	GET /recovery HTTP/1.1
            	            	
            	            	
            	            	" does not contain "Broken pipe"
            	Test:       	TestPanicWithBrokenPipe/Broken_pipe
    --- PASS: TestPanicWithBrokenPipe/connection_reset_by_peer (0.00s)
=== RUN   TestResponseWriterReset

update after output:

=== RUN   TestPanicWithBrokenPipe
=== RUN   TestPanicWithBrokenPipe/broken_pipe
[GIN-debug] [WARNING] Running in "debug" mode. Switch to "release" mode in production.
 - using env:	export GIN_MODE=release
 - using code:	gin.SetMode(gin.ReleaseMode)
[GIN-debug] GET    /recovery                 --> github.com/gin-gonic/gin.TestPanicWithBrokenPipe.func1.1 (2 handlers)
=== RUN   TestPanicWithBrokenPipe/connection_reset_by_peer
[GIN-debug] [WARNING] Running in "debug" mode. Switch to "release" mode in production.
 - using env:	export GIN_MODE=release
 - using code:	gin.SetMode(gin.ReleaseMode)
[GIN-debug] GET    /recovery                 --> github.com/gin-gonic/gin.TestPanicWithBrokenPipe.func1.1 (2 handlers)
--- PASS: TestPanicWithBrokenPipe (0.00s)
    --- PASS: TestPanicWithBrokenPipe/broken_pipe (0.00s)
    --- PASS: TestPanicWithBrokenPipe/connection_reset_by_peer (0.00s)

@codecov
Copy link

codecov bot commented Nov 26, 2018

Codecov Report

Merging #1669 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1669   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files          41       41           
  Lines        1993     1993           
=======================================
  Hits         1981     1981           
  Misses          9        9           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54e9610...d5322dc. Read the comment docs.

@thinkerou thinkerou added the bug label Nov 27, 2018
@thinkerou thinkerou added this to the 1.4 milestone Nov 27, 2018
@thinkerou thinkerou merged commit f463d84 into gin-gonic:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants