Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split examples to alone repo #1776

Merged
merged 6 commits into from
Mar 1, 2019
Merged

Split examples to alone repo #1776

merged 6 commits into from
Mar 1, 2019

Conversation

thinkerou
Copy link
Member

@thinkerou thinkerou commented Feb 21, 2019 •
edited
Loading

ref: #1775

  • merge or close all pull request about examples/*

  • remove embedmd from README.md and .travis.yml

  • remove examples/*

  • add README.md at examples dir

  • add gin-gonic/examples repo and move examples

  • sync git log

@thinkerou thinkerou changed the title Split examples Split examples to alone repo Feb 21, 2019
@thinkerou thinkerou changed the title Split examples to alone repo wip: Split examples to alone repo Feb 21, 2019
@thinkerou thinkerou self-assigned this Feb 21, 2019
@codecov
Copy link

codecov bot commented Feb 21, 2019 •
edited
Loading

Codecov Report

Merging #1776 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1776   +/-   ##
======================================
  Coverage    98.5%   98.5%           
======================================
  Files          41      41           
  Lines        2073    2073           
======================================
  Hits         2042    2042           
  Misses         19      19           
  Partials       12      12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb9e90...75604f9. Read the comment docs.

@thinkerou thinkerou added this to the 1.x milestone Feb 22, 2019
@thinkerou thinkerou closed this Feb 22, 2019
@thinkerou thinkerou reopened this Feb 22, 2019
@solarhell solarhell mentioned this pull request Feb 23, 2019
Closed
@thinkerou
Copy link
Member Author

thinkerou commented Feb 25, 2019 •
edited
Loading

  • I don't update anything for govendor, why download package failed?

@thinkerou thinkerou modified the milestones: 1.x, 1.5 Feb 26, 2019
@thinkerou
Copy link
Member Author

thinkerou commented Mar 1, 2019 •
edited
Loading

ref issue or pull request

@thinkerou thinkerou changed the title wip: Split examples to alone repo Split examples to alone repo Mar 1, 2019
@thinkerou
Copy link
Member Author

@appleboy @javierprovecho the pull request ready, please review, thanks!

@thinkerou thinkerou modified the milestones: 1.5, 1.4 Mar 1, 2019
@thinkerou thinkerou merged commit 0feaf8c into gin-gonic:master Mar 1, 2019
@dangkaka dangkaka mentioned this pull request Mar 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleboy appleboy appleboy approved these changes

@javierprovecho javierprovecho Awaiting requested review from javierprovecho

Assignees

@thinkerou thinkerou

Labels
None yet
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkerou @appleboy